antonlyap/bliss-rs
1
0
Fork 0
Code Issues Pull Requests Packages Activity

Use set for paths-to-update comparison

Browse Source 
With about 140k tracks the update operation takes a long time. A
flamegraph shows update_library_convert_extra_info as taking almost all
of that time and slice_contains in particular.

With the previous release 0.2.9 updates where very fast and got to the
actual analyzing part right away. With 0.3.2 it spends a lot of time
before it even gets to analyzing. And it seems to be slower to start up
the more songs you have analyzed.

Blissify 0.2.9 seemed to use a HashSet too :)
This commit is contained in:
toofar 2022-10-14 22:41:48 +13:00
parent 10cddd64a3
commit eef648bda5
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/library.rs
View File

@ -129,7 +129,7 @@ use rusqlite::Params;
use rusqlite::Row; use rusqlite::Row;
use serde::de::DeserializeOwned; use serde::de::DeserializeOwned;
use serde::Serialize; use serde::Serialize;
use std::collections::HashMap; use std::collections::{HashMap, HashSet};
use std::env; use std::env;
use std::fs; use std::fs;
use std::fs::create_dir_all; use std::fs::create_dir_all;
@ -661,7 +661,7 @@ impl<Config: AppConfigTrait> Library<Config> {
Ok(row.get_unwrap::<usize, String>(0)) Ok(row.get_unwrap::<usize, String>(0))
})? })?
.map(|x| PathBuf::from(x.unwrap())) .map(|x| PathBuf::from(x.unwrap()))
.collect::<Vec<PathBuf>>(); .collect::<HashSet<PathBuf>>();
return_value return_value
}; };